[webkit-reviews] review granted: [Bug 60503] Refactor RenderObject::draggableNode : [Attachment 92894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 19:42:05 PDT 2011


Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 60503: Refactor RenderObject::draggableNode
https://bugs.webkit.org/show_bug.cgi?id=60503

Attachment 92894: Patch
https://bugs.webkit.org/attachment.cgi?id=92894&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92894&action=review

Yes, this looks just like a refactor.

> Source/WebCore/page/DragController.cpp:598
> +	       if (uaOK && dragMode == DRAG_AUTO
> +		       && mayStartDragAtEventLocation(src, IntPoint(x, y),
node)) {

I think it's ok to do indention fixes when refactoring.  I mean, you do that
when you pull out functions, etc.


More information about the webkit-reviews mailing list