[webkit-reviews] review granted: [Bug 60396] Add RIAA-style DenormalDisabler class to disable denormals which hurt audio performance : [Attachment 92834] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 60396: Add RIAA-style DenormalDisabler class to disable denormals which
hurt audio performance
https://bugs.webkit.org/show_bug.cgi?id=60396

Attachment 92834: Patch
https://bugs.webkit.org/attachment.cgi?id=92834&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92834&action=review

Couple of minor comments; feel free to fix upon landing.

> Source/WebCore/ChangeLog:5
> +	   Add RIAA-style DenormalDisabler class to disable denormals which
hurt audio performance.

RIAA -> RAII

> Source/WebCore/platform/audio/DenormalDisabler.h:50
> +	   asm volatile("stmxcsr %0" : "=m" (*&result));

It looks like the *& isn't needed here or on the ldmxcsr; see
http://gcc.gnu.org/bugzilla/attachment.cgi?id=11062 .