[webkit-reviews] review granted: [Bug 60496] Command-~/=?UTF-8?Q?Expos=C3=A9=20to=20another=20window=20while=20?=<video> is in full screen, breaks Safari, eventually leading to crash : [Attachment 92832] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 60496: Command-~/Exposé to another window while <video> is in full screen,
breaks Safari, eventually leading to crash
https://bugs.webkit.org/show_bug.cgi?id=60496

Attachment 92832: Patch
https://bugs.webkit.org/attachment.cgi?id=92832&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92832&action=review

> Source/WebKit/mac/WebView/WebFullScreenController.mm:275
> +	   WebView* webView = [self webView];
> +	   NSWindow* webWindow = [webView window];

This doesn’t follow our usual style of putting the * in the traditional place
for Objective-C classes.

> Source/WebKit/mac/WebView/WebFullScreenController.mm:292
> +	   // In Lion, NSWindow will animate into and out of orderOut
operations.  Supress that

Extra space here after period. Misspelling of suppress.

> Source/WebKit/mac/WebView/WebFullScreenController.mm:531
> +	   NSWindow* webWindow = [[self webView] window];

Same style issue here.

> Source/WebKit/mac/WebView/WebFullScreenController.mm:533
> +	   // In Lion, NSWindow will animate into and out of orderOut
operations.  Supress that

Same mistakes here.

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:256
> +	   NSWindow* webWindow = [_webViewPlaceholder.get() window];
> +#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
> +	   // In Lion, NSWindow will animate into and out of orderOut
operations.  Supress that

Same issue again.