[webkit-reviews] review denied: [Bug 60487] [Qt] DRT eventSender.addTouchPoint method is not setting the start position : [Attachment 92814] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 60487: [Qt] DRT eventSender.addTouchPoint method is not setting the start
position
https://bugs.webkit.org/show_bug.cgi?id=60487

Attachment 92814: patch
https://bugs.webkit.org/attachment.cgi?id=92814&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92814&action=review

Nice catch. r- because the code is ugly. Not your fault, but let's fix it. :)

> Tools/DumpRenderTree/qt/EventSenderQt.cpp:406
>      QTouchEvent::TouchPoint point(id);
>      m_touchPoints.append(point);
>      updateTouchPoint(index, x, y);
> +    m_touchPoints[index].setStartPos(QPointF(x, y));
>      m_touchPoints[index].setState(Qt::TouchPointPressed);

This code is unnecessarily confusing, we should fix it while we're visiting.
Something like:

QTouchEvent::TouchPoint point(id);
point.setPos(QPointF(x, y));
point.setStartPos(QPointF(x, y));
point.setState(Qt::TouchPointPressed);
m_touchPoints.append(point);

And of course the 'index' variable won't be needed after this cleanup.