[webkit-reviews] review requested: [Bug 60484] ChromeClient::webView() is only needed for Chromium port : [Attachment 92811] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 60484: ChromeClient::webView() is only needed for Chromium port
https://bugs.webkit.org/show_bug.cgi?id=60484

Attachment 92811: Patch
https://bugs.webkit.org/attachment.cgi?id=92811&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Source/WebCore:

* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::webView): Wrap in #if
PLATFORM(CHROMIUM)/#endif.
* page/ChromeClient.h:
(WebCore::ChromeClient::webView): Ditto.
* page/brew/ChromeClientBrew.h:
(WebCore::ChromeClientBriew::webView): Removed.

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::webView): Removed.

Source/WebKit/gtk:

NOTE: This reverts commit r85832.

* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::webView): Restored typed, non-virtual
method.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::imContextCommitted): Removed unnecessary static_cast.
(WebKit::imContextPreeditChanged): Ditto.
* webkit/webkitwebview.cpp:
(WebKit::kit): Ditto.

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.h:
(WebCore::ChromeClientHaiku::webView): Removed.

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::webView): Restored typed, non-virtual method.
* WebView/WebFrame.mm:
(kit): Removed unnecessary static_cast.

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::webView): Removed.

Source/WebKit/win:

NOTE: This reverts commit r85831.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::webView): Restored typed, non-virtual method.
* WebView.cpp:
(kit): Removed unnecessary static_cast.

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.h:
(WebKit::ChromeClientWinCE::webView): Removed.

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWX::webView): Removed.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::webView): Removed.
---
 26 files changed, 123 insertions(+), 17 deletions(-)