[webkit-reviews] review granted: [Bug 60388] Fix some unnecessary includes in headers : [Attachment 92782] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 09:19:09 PDT 2011


Darin Adler <darin at apple.com> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 60388: Fix some unnecessary includes in headers
https://bugs.webkit.org/show_bug.cgi?id=60388

Attachment 92782: Patch
https://bugs.webkit.org/attachment.cgi?id=92782&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review

Looks good. Hard to judge a patch like this except by whether everything keeps
compiling!

> Source/WebCore/css/CSSFontFaceSrcValue.h:37
>  #if ENABLE(SVG_FONTS)
> -#include "SVGFontFaceElement.h"
> +class SVGFontFaceElement;
>  #endif

For the future, I’m not sure we need to put a forward-declaration of a class
inside an #if. There is little or no harm to just declaring the name of a class
unconditionally.


More information about the webkit-reviews mailing list