[webkit-reviews] review granted: [Bug 60475] Style fix: Function names must begin with lowercase letter. : [Attachment 92796] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 60475: Style fix: Function names must begin with lowercase letter.
https://bugs.webkit.org/show_bug.cgi?id=60475

Attachment 92796: Patch
https://bugs.webkit.org/attachment.cgi?id=92796&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92796&action=review

> Source/WebCore/page/PageVisibilityState.h:47
>  #if ENABLE(PAGE_VISIBILITY_API)
> -String GetPageVisibilityStateString(PageVisibilityState);
> +String getPageVisibilityStateString(PageVisibilityState);
>  #endif

If your intent is to fix to match WebKit project style, then the name should
be:

    pageVisibilityStateString

We only use “get” in functions with out arguments; functions that simply return
a value use noun or adjective phrases.