[webkit-reviews] review granted: [Bug 60428] NRWT: debug messages from the workers are being logged twice : [Attachment 92684] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 60428: NRWT: debug messages from the workers are being logged twice
https://bugs.webkit.org/show_bug.cgi?id=60428

Attachment 92684: Patch
https://bugs.webkit.org/attachment.cgi?id=92684&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92684&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:328

> +	       configure_logging = False
> +	       if sys.platform == 'win32':
> +		   # The unix multiprocessing implementation clones the
> +		   # log handler configuration into the child processes,
> +		   # but the win implementation doesn't.
> +		   configure_logging = True

how about:
# ...
# ...
# ...
configure_logging = sys.platform == 'win32'