[webkit-reviews] review granted: [Bug 58999] RGBA colors in outlines show overpainting at the corners : [Attachment 92774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 08:28:37 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ben Wells
<benwells at chromium.org>'s request for review:
Bug 58999: RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Attachment 92774: Patch
https://bugs.webkit.org/attachment.cgi?id=92774&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92774&action=review

r+ but please consider a followup to change RenderObject to fill a path when
possible.

> Source/WebCore/rendering/RenderObject.cpp:1058
> +    bool useTransparencyLayer = outlineColor.hasAlpha();
> +    if (useTransparencyLayer) {
> +	  
graphicsContext->beginTransparencyLayer(static_cast<float>(outlineColor.alpha()
) / 255);
> +	   outlineColor = Color(outlineColor.red(), outlineColor.green(),
outlineColor.blue());
> +    }

Transparency layers are pretty expensive, so it would be nice to have code here
that fills a path, rather than drawing 4 sides independently, if the outline is
solid and the color has alpha. It would be nice to just share code with border
drawing if possible.


More information about the webkit-reviews mailing list