[webkit-reviews] review granted: [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch : [Attachment 92742] Patch 10: Glue layer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 9 01:10:48 PDT 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 60439: [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2
branch
https://bugs.webkit.org/show_bug.cgi?id=60439
Attachment 92742: Patch 10: Glue layer
https://bugs.webkit.org/attachment.cgi?id=92742&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92742&action=review
> Source/WebKit/qt/WebCoreSupport/PageClientQt.h:50
> + void scroll(float dx, float dy);
scrollBy ?
> Source/WebKit/qt/WebCoreSupport/PageClientQt.h:52
> + virtual ~TextureMapperNodeClientQt();
Why not place it next to the ctor?
> Source/WebKit/qt/WebCoreSupport/PageClientQt.h:57
> +protected:
Are you inheriting from this class?
More information about the webkit-reviews
mailing list