[webkit-reviews] review granted: [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch : [Attachment 92713] Patch 7: WebGL changes

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 60439: [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2
branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Attachment 92713: Patch 7: WebGL changes
https://bugs.webkit.org/attachment.cgi?id=92713&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92713&action=review

How useful is this fallback path?

> Source/WebCore/ChangeLog:11
> +	   No new tests. Tests in LayoutTests/compositing cover this.

compositing? webgl tests are there?

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:182
> +    virtual void paintToTextureMapper(TextureMapper*,
> +			  const FloatRect& target,
> +			  const TransformationMatrix&,
> +			  float opacity,
> +			  BitmapTexture* mask) const;

one line please