[webkit-reviews] review granted: [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch : [Attachment 92711] Patch 5: Qt backend changes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 8 04:46:53 PDT 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 60439: [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2
branch
https://bugs.webkit.org/show_bug.cgi?id=60439
Attachment 92711: Patch 5: Qt backend changes
https://bugs.webkit.org/attachment.cgi?id=92711&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92711&action=review
> Source/WebCore/platform/graphics/qt/TextureMapperQt.cpp:103
> QPainter* painter = m_currentSurface ? &m_currentSurface->m_painter :
m_painter;
You are using this in different places? make an inline private method for it?
> Source/WebCore/platform/graphics/qt/TextureMapperQt.cpp:113
> + QPainter* painter = m_currentSurface ? &m_currentSurface->m_painter :
m_painter;
like here
> Source/WebCore/platform/graphics/qt/TextureMapperQt.cpp:119
> + return IntSize(m_painter->device()->width(),
m_painter->device()->height());
What if there is a currentSurface?
More information about the webkit-reviews
mailing list