[webkit-reviews] review granted: [Bug 60380] Fix compile with gcc 4.6.0 : [Attachment 92698] proposed patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 7 15:55:15 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Dawit A. <adawit at kde.org>'s
request for review:
Bug 60380: Fix compile with gcc 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60380

Attachment 92698: proposed patch v5
https://bugs.webkit.org/attachment.cgi?id=92698&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92698&action=review

As far as I can tell you're not a committer. So, I will make these changes for
you and land your patch.

> Source/JavaScriptCore/ChangeLog:8
> +	   Remove unused local variable from code
> +
> +	   Fix compile with gcc 4.6.0
> +	   https://bugs.webkit.org/show_bug.cgi?id=60380

This change log entry does not have the right format. The format is bug title,
bug url, then description. Also, GCC is an acronym so "gcc" should be "GCC"
(although I can see from the diff that we landed change log entries with
"gcc").

Also, we use complete sentences.


More information about the webkit-reviews mailing list