[webkit-reviews] review granted: [Bug 60421] Custom scrollbars nested inside an overlay scrollbar overflow region end up painting twice : [Attachment 92665] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 17:47:58 PDT 2011


Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 60421: Custom scrollbars nested inside an overlay scrollbar overflow region
end up painting twice
https://bugs.webkit.org/show_bug.cgi?id=60421

Attachment 92665: Patch
https://bugs.webkit.org/attachment.cgi?id=92665&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92665&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2254
> +    // If this is the special overlay scrollbar painting pass, then don't
re-paint any
> +    // non-overlay scrollbars. Only custom-CSS scrollbars will be
non-overlay in this
> +    // context.

This comment seems a little long. Maybe you could remove more of what's
redundant with the code and concentrate on the why part of this?


More information about the webkit-reviews mailing list