[webkit-reviews] review granted: [Bug 53564] Make canHaveChildrenForEditing more efficient : [Attachment 82434] updated patch (works on GTK)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 53564: Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564

Attachment 82434: updated patch (works on GTK)
https://bugs.webkit.org/attachment.cgi?id=82434&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82434&action=review

OK.  I feel like this kinda makes it harder to tell what elements we're white
listing... I'm also wondering how people adding new elements are going to get
this right.

> Source/WebCore/editing/htmlediting.cpp:76
> +#if !ENABLE(DATAGRID)
> +    if (node->hasTagName(datagridTag))
> +	   ignoreContent = true;
>  #endif

I'm confused why this can't use the canContainRangeEndPoint stuff.