[webkit-reviews] review canceled: [Bug 56749] Enable skia gpu rendering for content layers : [Attachment 92141] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 13:08:51 PDT 2011


Alok Priyadarshi <alokp at chromium.org> has canceled Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 56749: Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749

Attachment 92141: proposed patch
https://bugs.webkit.org/attachment.cgi?id=92141&action=review

------- Additional Comments from Alok Priyadarshi <alokp at chromium.org>
Adrienne: Removed most of ifdefs from LayerTilerChromium. The ones remaining
are because the CG path is not implemented yet. There are two uploaders in
LayerTilerChromium because it also needs to support ImageLayerChromium that
directly uses uploadPixels. I could not think of a clean way for
ImageLayerChromium to express which uploader it wants to use.

Addressed other comments from Vangelis and James.


More information about the webkit-reviews mailing list