[webkit-reviews] review requested: [Bug 60281] Associated URL loaders need to keep a reference to downloaded files : [Attachment 92629] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 12:57:48 PDT 2011


Brett Wilson (Google) <brettw at chromium.org> has asked  for review:
Bug 60281: Associated URL loaders need to keep a reference to downloaded files
https://bugs.webkit.org/show_bug.cgi?id=60281

Attachment 92629: New patch
https://bugs.webkit.org/attachment.cgi?id=92629&action=review

------- Additional Comments from Brett Wilson (Google) <brettw at chromium.org>
This patch adds a references to bug 60397 which I filed to track the threading
issue.

I talked to mnordman and we don't know how to test this in a reasonable way in
the WebKit repo (there is already a test in Chrome which is how we found this
problem). This functionality is really just exposed via the WebKit API, the
downloaded file objects currently are not used anywhere in WebKit and are not
exposed via script.

The main option is to hook this up to the WebKit API unit tests. But those are
literally unit tests and aren't hooked up to the network or blob systems. What
a test would look like for this would be to synthesize a resource request,
synthesize a response with a file, and then somehow hook into the blob system
(I don't know how this works or how hard it might be) to watch for the "unref
this file" message and make sure it comes later. This test seems to rather
complex and of unclear benefit to me. Thoughts or other ideas?


More information about the webkit-reviews mailing list