[webkit-reviews] review denied: [Bug 59912] Automated Bug 5768 test from manual test. : [Attachment 92032] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 12:23:36 PDT 2011


Daniel Bates <dbates at webkit.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 59912: Automated Bug 5768 test from manual test.
https://bugs.webkit.org/show_bug.cgi?id=59912

Attachment 92032: Patch
https://bugs.webkit.org/attachment.cgi?id=92032&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
This test seems better suited as a pixel-test/repainting-test instead of a
text-only test because the description for bug #5768
(https://bugs.webkit.org/show_bug.cgi?id=5768#c0), in particular the last two
sentences, describes a painting/repainting issue. This also coincides with the
changes described in the patch for the bug (and additional bug comments) and
the omission of dumpAsText() from the manual test case that were landed in
changeset 11648, <http://trac.webkit.org/changeset/11648>.

I am hesitant to land a test that differs much from the original test case
since we are working with limited information due to the amount of time that
has elapsed since bug #5768 was fixed.


More information about the webkit-reviews mailing list