[webkit-reviews] review granted: [Bug 60285] REGRESSION (WebKit2): A white rectangle covers up important UI elements when composing a new message at mail.yahoo.com with BrowserPlus! plug-in installed : [Attachment 92602] Show/hide windowed plugins according to the plugin element's visibility CSS property

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 60285: REGRESSION (WebKit2): A white rectangle covers up important UI
elements when composing a new message at mail.yahoo.com with BrowserPlus!
plug-in installed
https://bugs.webkit.org/show_bug.cgi?id=60285

Attachment 92602: Show/hide windowed plugins according to the plugin element's
visibility CSS property
https://bugs.webkit.org/attachment.cgi?id=92602&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92602&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:297
> +void NetscapePlugin::platformVisibilityDidChange()
> +{
> +    // FIXME: Implement this. <http://webkit.org/b/44368>.
> +    notImplemented();
> +}

Do we really need this on Mac since there's no such thing as windowed plug-ins
there?

> Source/WebKit2/WebProcess/Plugins/PluginController.h:49
> +    virtual bool isPluginVisible() = 0;

This needs to be implemented in PluginControllerProxy or the
ENABLE_PLUGIN_PROCESS build will break.