[webkit-reviews] review requested: [Bug 58863] [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing : [Attachment 92589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 09:29:24 PDT 2011


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 58863: [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html
failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Attachment 92589: Patch
https://bugs.webkit.org/attachment.cgi?id=92589&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch. For mouse move events we need to use the bitmask returned by
QMouseEvent::buttons() instead of the return value of QMouseEvent::button()
because QMouseEvent::button() returns Qt::NoButton as per
<http://doc.qt.nokia.com/latest/qmouseevent.html#button>.


More information about the webkit-reviews mailing list