[webkit-reviews] review denied: [Bug 60305] RenderLayer should not inherit from ScrollableArea : [Attachment 92512] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 01:17:45 PDT 2011


Adam Barth <abarth at webkit.org> has denied  review:
Bug 60305: RenderLayer should not inherit from ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=60305

Attachment 92512: Patch
https://bugs.webkit.org/attachment.cgi?id=92512&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch causes many test failures:


Regressions: Unexpected text diff mismatch : (20)
  fast/block/float/marquee-shrink-to-avoid-floats.html = TEXT
  fast/css/MarqueeLayoutTest.html = TEXT
  fast/css/text-overflow-ellipsis-bidi.html = TEXT
  fast/css/text-overflow-ellipsis-strict.html = TEXT
  fast/css/text-overflow-ellipsis.html = TEXT
  fast/events/autoscroll-in-textfield.html = TEXT
  fast/forms/date-input-visible-strings.html = TEXT
  fast/forms/input-readonly-autoscroll.html = TEXT
  fast/forms/search-rtl.html = TEXT
  fast/html/marquee-scroll.html = TEXT
  fast/html/marquee-scrollamount.html = TEXT
  fast/inline-block/003.html = TEXT
  fast/repaint/intermediate-layout-position-clip.html = TEXT
  fast/repaint/line-in-scrolled-clipped-block.html = TEXT
  fast/repaint/text-selection-rect-in-overflow-2.html = TEXT
  fast/repaint/text-selection-rect-in-overflow.html = TEXT
  fast/table/colspanMinWidth-vertical.html = TEXT
  fast/transforms/scrollIntoView-transformed.html = TEXT
  inspector/console/console-command-clear.html = TEXT
  svg/custom/scroll-hit-test.xhtml = TEXT


More information about the webkit-reviews mailing list