[webkit-reviews] review denied: [Bug 60297] Add cmd line flag to chromium version of DumpRenderTree to select GraphicsContext3D implementation : [Attachment 92489] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 5 17:31:17 PDT 2011
Kenneth Russell <kbr at google.com> has denied Gregg Tavares <gman at google.com>'s
request for review:
Bug 60297: Add cmd line flag to chromium version of DumpRenderTree to select
GraphicsContext3D implementation
https://bugs.webkit.org/show_bug.cgi?id=60297
Attachment 92489: Patch
https://bugs.webkit.org/attachment.cgi?id=92489&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92489&action=review
Looks good except for the "reviewed by" line. Please upload another version
fixing that issue and we can submit it via the commit queue.
> ChangeLog:3
> + Reviewed by Kenneth Russell
Actually you should leave this line as "Reviewed by NOBODY (OOPS)!". The tools
will fill in the reviewer's name. All other lines containing OOPS need to be
addressed or removed.
> ChangeLog:8
> + https://bugs.webkit.org/show_bug.cgi?id=60297
In the future, the preferred format is:
[synopsis]
[bug ID]
but this is fine.
More information about the webkit-reviews
mailing list