[webkit-reviews] review granted: [Bug 60310] update-webkit should handle Internal using a different VCS than OpenSource. : [Attachment 92492] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 16:28:49 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 60310: update-webkit should handle Internal using a different VCS than
OpenSource.
https://bugs.webkit.org/show_bug.cgi?id=60310

Attachment 92492: Patch
https://bugs.webkit.org/attachment.cgi?id=92492&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review

OK

>> Tools/ChangeLog:8
>> +	    isGit() and isSVN() cache their results, so Internal will always be

> 
> Are these methods used anywhere anymore?  Maybe they can be removed?

Yes, these functions are used in svn-apply and svn-unapply.


More information about the webkit-reviews mailing list