[webkit-reviews] review denied: [Bug 60235] Make RenderStyle::setPageBreakInside() reject unsupported enum values. : [Attachment 92379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 5 16:13:42 PDT 2011
Eric Seidel <eric at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 60235: Make RenderStyle::setPageBreakInside() reject unsupported enum
values.
https://bugs.webkit.org/show_bug.cgi?id=60235
Attachment 92379: Patch
https://bugs.webkit.org/attachment.cgi?id=92379&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Still need to understand why PBAlways is not a valid value here. You mentioned
in another bug that the enums were "too loose". Is it possible to ever call
this with PBALWAYS? or should we ASSERT not? In either case we should have a
comment her to explain why this check is needed/wanted.
I don't think you actually need the inline. The compiler implicitly adds
inline to all declaration-inline definitions was my understanding. (But I'm
not a c++ expert!)
More information about the webkit-reviews
mailing list