[webkit-reviews] review denied: [Bug 60295] Add an option to NRWT to skip failing tests : [Attachment 92461] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied  review:
Bug 60295: Add an option to NRWT to skip failing tests
https://bugs.webkit.org/show_bug.cgi?id=60295

Attachment 92461: Patch
https://bugs.webkit.org/attachment.cgi?id=92461&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92461&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:364
> +		   failing = self._expectations.get_tests_with_result_type(
> +				  test_expectations.FAIL)

This will only exclude tests marked "FAIL" in test_expectaitons. It won't
exclude TEXT, IMAGE, IMAGE+TEXT, etc. As the code is now, you'll need to
exclude each one. You can iterate through TestExpectations.EXPECTATIONS for all
the values.