[webkit-reviews] review denied: [Bug 60228] Isolate member functions and variables for selection in EventHandler : [Attachment 92445] initial patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 60228: Isolate member functions and variables for selection in EventHandler
https://bugs.webkit.org/show_bug.cgi?id=60228

Attachment 92445: initial patch
https://bugs.webkit.org/attachment.cgi?id=92445&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92445&action=review

> Source/WebCore/page/EventHandler.cpp:-173
>  
> -EventHandler::EventHandler(Frame* frame)
> -    : m_frame(frame)
> -    , m_mousePressed(false)

Should probably not move these to keep the diff small.

> Source/WebCore/page/EventHandler.cpp:192
> +void
EventHandler::SelectionController::selectClosestWordFromMouseEvent(Frame*
frame, const MouseEventWithHitTestResults& result)

seems like you just want a m_frame pointer, since all these methods take a
Frame*