[webkit-reviews] review granted: [Bug 59731] REGRESSION(r83522): backspace should not go back on Linux : [Attachment 92295] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 59731: REGRESSION(r83522): backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731

Attachment 92295: Patch
https://bugs.webkit.org/attachment.cgi?id=92295&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92295&action=review

Whether it would be better as separate tests is clearly arguable (e.g. I like
it as is). Sounds like Ryosuke, would prefer this test split up, but is not
opposed to this staying a single test.

> LayoutTests/fast/events/backspace-navigates-back-expected.txt:2
> +This test passes if it prints "PASS: test complete".

s/prints "PASS: test complete"./logs "PASS: test complete" to the console. Just
to be more clear (e.g. printing could be printing it to the page.

> LayoutTests/fast/events/backspace-navigates-back.html:86
> +window.onpageshow = function() {

Can you add something like the following:
if (!window.eventSender) {
    document.body.innerHTML += " This test requires eventSender and layoutTest
controller. It cannot be run manually.";
    return;
}