[webkit-reviews] review granted: [Bug 28220] Layout tests shouldn't have to hard code media controller element locations : [Attachment 92408] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 28220: Layout tests shouldn't have to hard code media controller element
locations
https://bugs.webkit.org/show_bug.cgi?id=28220

Attachment 92408: proposed patch
https://bugs.webkit.org/attachment.cgi?id=92408&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92408&action=review

Excellent work!

> LayoutTests/media/video-test.js:248
> +    var button;
> +    var controlsShadow =
layoutTestController.shadowRoot(element).firstChild.firstChild;
> +    for (child = controlsShadow.firstChild; child; child =
child.nextSibling) {
> +	   if (layoutTestController.shadowPseudoId(child) ==
"-webkit-media-controls-" + id) {
> +	       button = child;
> +	       break;
> +	   }
> +    }

It's not possible to do something like getElementById on the shadow root?