[webkit-reviews] review granted: [Bug 60224] [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0. : [Attachment 92339] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 5 06:43:47 PDT 2011
Andreas Kling <kling at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 60224: [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr
rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224
Attachment 92339: Patch
https://bugs.webkit.org/attachment.cgi?id=92339&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92339&action=review
Did you performance test this?
> Source/WebCore/ChangeLog:9
> + but webkit already have a nullptr class if there is no c++0x
support.
webkit -> WebKit
have -> has
> Source/WebKit/qt/ChangeLog:9
> + We should use nullptr rather than 0. nullptr will be added in the
new C++ standard
> + but webkit already have a nullptr class if there is no c++0x
support.
Ditto.
More information about the webkit-reviews
mailing list