[webkit-reviews] review denied: [Bug 59688] Web Inspector: TextEditor should support editing a range. : [Attachment 91661] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 59688: Web Inspector: TextEditor should support editing a range.
https://bugs.webkit.org/show_bug.cgi?id=59688

Attachment 91661: Patch.
https://bugs.webkit.org/attachment.cgi?id=91661&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91661&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:141
> +	   if (!this._resource.isEditable())

This looks weird. This method should not be called for read-only resources.

> Source/WebCore/inspector/front-end/SourceFile.js:241
> +	   if (!WebInspector.debugMode) {

Remove this?

> Source/WebCore/inspector/front-end/SourceFile.js:247
> +	       script = this._scripts[i];

script -> var script, r- for this.

> Source/WebCore/inspector/front-end/SourceFrame.js:992
> +	   // Should be implemented by subclasses.

Add return null; ?

> Source/WebCore/inspector/front-end/textViewer.css:47
> +    -webkit-user-modify: read-only;

This will turn background of almost all resources into grey when content
editing is disabled in Preferences, not sure this is what we want to achieve.