[webkit-reviews] review granted: [Bug 60192] Web Inspector: add test for shadow DOM access in the console API : [Attachment 92292] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 03:33:24 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 60192: Web Inspector: add test for shadow DOM access in the console API
https://bugs.webkit.org/show_bug.cgi?id=60192

Attachment 92292: patch
https://bugs.webkit.org/attachment.cgi?id=92292&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92292&action=review

> LayoutTests/http/tests/inspector/elements-test.js:81
> +InspectorTest.selectNode = function(node, callback)

Can you change InspectorTest.selectNodeWithId to call this method as well?

> LayoutTests/inspector/console/console-shadow-dom-access.html:25
> +	   expressions.splice(0, 1);

var expression = expressions.shift()


More information about the webkit-reviews mailing list