[webkit-reviews] review denied: [Bug 60255] Refactor TextRun creation : [Attachment 92386] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 01:33:32 PDT 2011


mitz at webkit.org has denied Nikolas Zimmermann <zimmermann at kde.org>'s request
for review:
Bug 60255: Refactor TextRun creation
https://bugs.webkit.org/show_bug.cgi?id=60255

Attachment 92386: Patch v2
https://bugs.webkit.org/attachment.cgi?id=92386&action=review

------- Additional Comments from mitz at webkit.org
This patch makes the code bigger (by about 100 lines, if I counted correctly)
and more complicated; and turns several private members into public ones for no
good reason. It appears that whatever benefit there is in this change, it can
be achieved by adding or modifying TextRun constructors and factoring code into
protected member functions in [SVG]InlineTextBox. Finally, the prefix “create”
is conventionally used for functions that transfer ownership of a
heap-allocated object, which is not the case here.


More information about the webkit-reviews mailing list