[webkit-reviews] review denied: [Bug 32163] Provide a choose-file signal to allow implementing a custom file chooser : [Attachment 82127] Implement WebKitFileChooser and choose-file, #3

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 32163: Provide a choose-file signal to allow implementing a custom file
chooser
https://bugs.webkit.org/show_bug.cgi?id=32163

Attachment 82127:  Implement WebKitFileChooser and choose-file, #3
https://bugs.webkit.org/attachment.cgi?id=82127&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82127&action=review

This really needs a proper review by folks knowledgeable in GTK.  Some of the
style errors look bogus, but some of them look like they should be addressed. 
I'm going to mark this R- for now to remove it from the queue, but please feel
encouraged to upload a new version of the paper.  You should probably find one
of the gtk folks on IRC and ask them to take a look at your patch.

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:602
> +static void chooseFileCb(WebKitWebView* webView, WebKitWebFrame*,
WebKitFileChooser* fileChooser)

Cb = ?	I don't understand this abbreviation.