[webkit-reviews] review requested: [Bug 60086] rebaseline_chromium_webkit_tests is not generating output diffs : [Attachment 92260] Patch

[bugzilla-daemon at webkit.org]

Steve Lacey <sjl at chromium.org> has asked  for review:
Bug 60086: rebaseline_chromium_webkit_tests is not generating output diffs
https://bugs.webkit.org/show_bug.cgi?id=60086

Attachment 92260: Patch
https://bugs.webkit.org/attachment.cgi?id=92260&action=review

------- Additional Comments from Steve Lacey <sjl at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92260&action=review

>> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:546
>> +	    baseline_relpath = self._filesystem.relpath(baseline_fullpath,
self._filesystem.getcwd())
> 
> Argh. It looks like this is another case of us getting bitten by SCM not
handling absolute paths. Assuming I'm right, this only works because of the
filesystem.chdir() having already occurred on line 393.
> 
> Can you move that chdir() and the corresponding # FIXME to somewhere near the
beginning of the main() method (around line 968) so that we can make this an
explicit invariant that rebaseline-chromium-webkit-tests operates from the top
of the webkit tree? 
> 
> Then, just delete the second argument to this call (so we can use the
default, which is IMO slightly less confusing).
> 
> Note that we need to actually do the chdir() rather than just passing in the
start dir, because Git is sufficiently broken on the Mac that it is confused by
symlinks.
> 
> Patch looks fine otherwise.

All done!

Also updated the unittest (oops...)