[webkit-reviews] review denied: [Bug 60246] Move burden of checking for BJustify box alignment into RenderStyle : [Attachment 92372] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 21:54:56 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 60246: Move burden of checking for BJustify box alignment into RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=60246

Attachment 92372: Patch
https://bugs.webkit.org/attachment.cgi?id=92372&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92372&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1029
> +    void setBoxAlign(EBoxAlignment a)

This guy now wants to be inlined like
http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/So
urce/WebCore/dom/Node.h&l=727&exact_package=chromium


More information about the webkit-reviews mailing list