[webkit-reviews] review denied: [Bug 37319] [Qt] tst_QWebFrame::overloadedSlots() fails : [Attachment 80610] Patch

[bugzilla-daemon at webkit.org]

Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> has denied  review:
Bug 37319: [Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Attachment 80610: Patch
https://bugs.webkit.org/attachment.cgi?id=80610&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80610&action=review

Noam, do you still plan to work on this?

> Source/WebCore/bridge/qt/qt_runtime.cpp:235
> +		   else if (object->inherits(&JSHTMLElement::s_info))
> +		       hint =
static_cast<QMetaType::Type>(qMetaTypeId<QWebElement>());

This doesn't affect overloadedSlots tests but do fix
tst_QWebFrame::getSetStaticProperty for me.

>>> Source/WebCore/bridge/qt/qt_runtime.cpp:-769
>>> -			 ret =
QVariant::fromValue<QWebElement>(QtWebElementRuntime::create((static_cast<JSDoc
ument*>(object))->impl()->documentElement()));
>> 
>> You're removing some logic re: JSDocument here, what's the reason?
> 
> Removing this code might brake fast/dom/nodesFromRect-basic.html  - see 
> http://trac.webkit.org/changeset/71004/

It breaks. From my understand you shouldn't remove JSDocument case here.
Actually, you could even 'dist = 0' for this case too.