[webkit-reviews] review denied: [Bug 60232] Associate <keygen> request with Frame. : [Attachment 92350] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 18:00:37 PDT 2011


Adam Barth <abarth at webkit.org> has denied Matt Mueller <mattm at chromium.org>'s
request for review:
Bug 60232: Associate <keygen> request with Frame.
https://bugs.webkit.org/show_bug.cgi?id=60232

Attachment 92350: patch
https://bugs.webkit.org/attachment.cgi?id=92350&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92350&action=review

> Source/WebCore/platform/android/SSLKeyGeneratorAndroid.cpp:29
> +#include "Document.h"

The platform directory cannot include files from WebCore that are outside the
platform directory.

Your root problem is that you need to go "up" to the client, not down to the
platform, to solve this problem.


More information about the webkit-reviews mailing list