[webkit-reviews] review granted: [Bug 59946] We need a utility class that read lines out of SharedBuffers : [Attachment 92128] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 59946: We need a utility class that read lines out of SharedBuffers
https://bugs.webkit.org/show_bug.cgi?id=59946

Attachment 92128: Patch
https://bugs.webkit.org/attachment.cgi?id=92128&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92128&action=review

Looks great!  Thanks.

> Source/WebCore/platform/SharedBufferCRLFLineReader.cpp:67
> +		   stringBuilder.append(currentCharacter);

I presume you looked also, but StringBuilder seems to handle
character-at-a-time building fine.

> Source/WebCore/platform/SharedBufferCRLFLineReader.cpp:87
> +    return String();

This line of code is unreachable, right?  Can we remove it without the compiler
getting sad?