[webkit-reviews] review granted: [Bug 60227] Add bundle API for making a page paint as the background of another page : [Attachment 92343] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 16:35:12 PDT 2011


Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 60227: Add bundle API for making a page paint as the background of another
page
https://bugs.webkit.org/show_bug.cgi?id=60227

Attachment 92343: Patch
https://bugs.webkit.org/attachment.cgi?id=92343&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92343&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:587
> +    if (m_underlayPage && m_underlayPage->mainFrame()->coreFrame()->view())
> +	  
m_underlayPage->mainFrame()->coreFrame()->view()->updateLayoutAndStyleIfNeededR
ecursive();

That’s a long common subexpression. Maybe use a local variable?


More information about the webkit-reviews mailing list