[webkit-reviews] review granted: [Bug 60220] Send unhandled wheel events to parent window on Windows : [Attachment 92334] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeff Miller <jeffm at apple.com>'s
request for review:
Bug 60220: Send unhandled wheel events to parent window on Windows
https://bugs.webkit.org/show_bug.cgi?id=60220

Attachment 92334: Patch
https://bugs.webkit.org/attachment.cgi?id=92334&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92334&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2633
> +#if PLATFORM(WIN)
> +	   if (!handled && m_currentlyProcessedWheelEvent)
> +	       wheelEventNotHandled(*m_currentlyProcessedWheelEvent);
> +#endif

Does this need to be Windows-only?

> Source/WebKit2/UIProcess/WebPageProxy.h:697
> +#if PLATFORM(WIN)
> +    void wheelEventNotHandled(NativeWebWheelEvent&) const;
> +#endif

Does this need to be Windows-only?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:343
> -    WebWheelEvent wheelEvent = WebEventFactory::createWebWheelEvent(ev);
> +    NativeWebWheelEvent wheelEvent = NativeWebWheelEvent(ev);
>      page->handleWheelEvent(wheelEvent);

Can we write this more simply, taking advantage of the default constructor?

> Source/WebKit2/UIProcess/win/WebView.cpp:438
> +    NativeWebWheelEvent wheelEvent = NativeWebWheelEvent(hWnd, message,
wParam, lParam);

We should write this with construction syntax, not construct an object and then
assign it.