[webkit-reviews] review granted: [Bug 60225] [results.html] Hide the entire table if all failures are expected : [Attachment 92340] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 4 16:11:01 PDT 2011
Eric Seidel <eric at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 60225: [results.html] Hide the entire table if all failures are expected
https://bugs.webkit.org/show_bug.cgi?id=60225
Attachment 92340: Patch
https://bugs.webkit.org/attachment.cgi?id=92340&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92340&action=review
OK.
> LayoutTests/fast/harness/results.html:387
> + if (globalState().results.uses_expectations_file) {
Could we do this as a helper method so that this can jsut early return instead?
More information about the webkit-reviews
mailing list