[webkit-reviews] review granted: [Bug 60223] The testing EWS bots should upload layout-test-results.zip to bugs after failures : [Attachment 92337] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 60223: The testing EWS bots should upload layout-test-results.zip to bugs
after failures
https://bugs.webkit.org/show_bug.cgi?id=60223

Attachment 92337: Patch
https://bugs.webkit.org/attachment.cgi?id=92337&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92337&action=review

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:188
>      @classmethod
>      def handle_script_error(cls, tool, state, script_error):
> +	   # FIXME: Why does this not exit(1) like the superclass does?
>	   log(script_error.message_with_output())

Probably a bug.

> Tools/Scripts/webkitpy/tool/commands/queues.py:242
> +    # FIXME: This probably belongs at a layer above AbstractPatchQueue, but
shared by CommitQueue and the EarlyWarningSystem.

above => below.