[webkit-reviews] review denied: [Bug 60221] Windows build of WebKit GTK needs to be able to find SystemInfo.h : [Attachment 92332] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 60221: Windows build of WebKit GTK needs to be able to find SystemInfo.h
https://bugs.webkit.org/show_bug.cgi?id=60221

Attachment 92332: Patch
https://bugs.webkit.org/attachment.cgi?id=92332&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92332&action=review

Seems okay, but the ChangeLog format does not look correct.

> Source/WebCore/ChangeLog:10
> +	   Add Source/WebCore/platform/win to teh paths searched
> +	   for headers, since Source/WebCore/platform/win/SystemInfo.h
> +	   header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
> +	   on Windows.
> +	   https://bugs.webkit.org/show_bug.cgi?id=60221
> +

teh -> the

The ChangeLog format should be

<bug title>
<bug url>

<description>

> Source/WebCore/ChangeLog:11
> +	   No new tests. (OOPS!)

You should remove this line or, even better, replace it with a short sentence
saying why tests are not necessary. :)