[webkit-reviews] review granted: [Bug 59877] [chromium]: Scroll position not restored on navigation back for in-page links : [Attachment 92312] patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 59877: [chromium]: Scroll position not restored on navigation back for
in-page links
https://bugs.webkit.org/show_bug.cgi?id=59877

Attachment 92312: patch
https://bugs.webkit.org/attachment.cgi?id=92312&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92312&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1045
> +    if (!m_inSameDocumentHistoryLoad && (m_frame->loader()->loadType() ==
FrameLoadTypeStandard

Any ideas as to why we save the scroll state in a getter in the first place? As
far as I can tell, that's been there since this code was upstreamed, but it
still seems odd.

I would be curious what breaks if we remove this altogether, but that can be
done separately, since I believe this is blocking a Chromium release. Maybe
just a FIXME?