[webkit-reviews] review denied: [Bug 60200] Make more member functions in EventHandler private : [Attachment 92302] cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 12:42:13 PDT 2011


Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 60200: Make more member functions in EventHandler private
https://bugs.webkit.org/show_bug.cgi?id=60200

Attachment 92302: cleanup
https://bugs.webkit.org/attachment.cgi?id=92302&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92302&action=review

> Source/WebCore/page/EventHandler.cpp:777
> -		   mainFrame->eventHandler()->setPanScrollInProgress(true);
> +		   mainFrame->eventHandler()->m_panScrollInProgress = true;

This seems strictly worse.  Can't we just make that method private?


More information about the webkit-reviews mailing list