[webkit-reviews] review denied: [Bug 60128] Compiler warning "eventWasHandled may be used without initialized" in WebView/WebHTMLView.mm. : [Attachment 92263] Initialize local variable eventWasHandled to avoid complier warning.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 4 11:54:02 PDT 2011
Alexey Proskuryakov <ap at webkit.org> has denied review:
Bug 60128: Compiler warning "eventWasHandled may be used without initialized"
in WebView/WebHTMLView.mm.
https://bugs.webkit.org/show_bug.cgi?id=60128
Attachment 92263: Initialize local variable eventWasHandled to avoid complier
warning.
https://bugs.webkit.org/attachment.cgi?id=92263&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm not thrilled with this change, because it makes the code a little more
fragile. If someone edits it and forgets to assign a result to the variable in
one of the branches, the compiler will no longer come to the rescue.
You should probably upstream a bigger chunk of code, and/or actually assign to
the variable instead of simply ifdefing out one branch in your port.
Marking r- for now, but you could convince me that it's fine to land as is.
More information about the webkit-reviews
mailing list