[webkit-reviews] review denied: [Bug 60077] [chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled : [Attachment 92155] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 4 10:55:16 PDT 2011
Kenneth Russell <kbr at google.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 60077: [chromium] Properly handle huge initial dimensions for 2d canvas
when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077
Attachment 92155: Patch
https://bugs.webkit.org/attachment.cgi?id=92155&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92155&action=review
> Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:101
> + if (!reset(size)) {
> + m_context.clear();
> + return;
> + }
The implementation of reset() references m_fbo which isn't initialized until
the following line. Was this patch tested?
More information about the webkit-reviews
mailing list