[webkit-reviews] review requested: [Bug 55875] [Qt][WK2][Symbian] Shared memory implementation for Symbian : [Attachment 92256] Updated patch with only SharedMemory impl for Symbian

[bugzilla-daemon at webkit.org]

Siddharth Mathur <siddharth.mathur at nokia.com> has asked  for review:
Bug 55875: [Qt][WK2][Symbian] Shared memory implementation for Symbian
https://bugs.webkit.org/show_bug.cgi?id=55875

Attachment 92256: Updated patch with only SharedMemory impl for Symbian
https://bugs.webkit.org/attachment.cgi?id=92256&action=review

------- Additional Comments from Siddharth Mathur <siddharth.mathur at nokia.com>
This patch has addressed most feedback from Kenneth in this bug and from Balazs
in Bug 55877. It's ready for review from my side. 

Kenneth: I did discuss the unresolved issue of when to Close() the chunk
(mentioned in the Changelog and in the SharedMemory d'tor) with other Symbian
and Qt gurus, and there are no clear solutions since Symbian client-server IPC
is not being used for this patch. I chose to use the less pure half-duplex
pipes here as they fit better with how other OSes do the WebKit2's IPC setup,
process launching, ownership transfer of the endpoint and read/writes. If we
decide to productize the Symbian port later, we can revisit the leaks.