[webkit-reviews] review granted: [Bug 60143] Entering full screen fails >= second time on Vimeo.com. : [Attachment 92200] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 60143: Entering full screen fails >= second time on Vimeo.com.
https://bugs.webkit.org/show_bug.cgi?id=60143

Attachment 92200: Patch
https://bugs.webkit.org/attachment.cgi?id=92200&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92200&action=review

> Source/WebCore/rendering/RenderFullScreen.cpp:42
> +	   // Force our layer to be updated by clearing its backing:

Strange non-standard use of a colon here.

I like that the comment says at least something the code does not. But It would
be better to have a comment that said something a bit closer to what the change
log note says. It’s not entirely clear how “clearing backing” is related to
correctly reparenting, and that’s what the comment could help with.