[webkit-reviews] review canceled: [Bug 31507] REGRESSION: [CAIRO] wrong drawing of Gradients and Patterns on texts : [Attachment 92192] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has canceled Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 31507: REGRESSION: [CAIRO] wrong drawing of Gradients and Patterns on texts
https://bugs.webkit.org/show_bug.cgi?id=31507

Attachment 92192: Patch
https://bugs.webkit.org/attachment.cgi?id=92192&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92192&action=review

>> Source/WebCore/platform/graphics/cairo/FontCairo.cpp:51
>> +	    static const float syntheticObliqueSkew = -tanf(14 * acosf(0) /
90);
> 
> I'd move this to the top of the file. This is common style in webkit for
static consts.

Sure thing. I'll upload a new patch.

>> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:102
>> +	    cairo_set_source(cr, cairoPattern.get());
> 
> Again, it looks like you change the CTM of the context to match the pattern
space instead of doing it the other way around. We have to d it in CG, because
CG doesn't provide a pattern transform. But cairo has a second transform. Just
unapply every change you made to the context to get italic fonts working from
the pattern and you're done. No extra changes to the CTM please.

I'm not sure I understand what you mean here. The pattern is transformed with
cairo_pattern_set_matrix in Pattern::createPlatformPattern, but not here. If I
understand what you're saying correctly, I'm doing what you suggest already. :)